rpk topic consume: expand the offset flag #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5d
suggested changes
Mar 24, 2022
We now: - can consume through the end and quit - can consume based on time - have many options for representing time ranges and durations Previously, consuming to an end offset left the client running in the paranoid case that a new partition could be discovered and consumed to that end offset. Now, we take a snapshot of the end offsets when rpk starts, consume to those, and quit. Closes #4073.
0x5d
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now:
Previously, consuming to an end offset left the client running in the
paranoid case that a new partition could be discovered and consumed to
that end offset. Now, we take a snapshot of the end offsets when rpk
starts, consume to those, and quit.
Closes #4073.
Release notes
Improvements
rpk topic consume -o, allowing consuming by time, and allows consuming to exit when the ends of partitions are reached.