Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Introduce docker hub container in deployment #677

Merged

Conversation

RafalKorepta
Copy link
Contributor

First version of redpanda operator was released to docker hub.
This gives users ability to install operator without cloning
the repo.

Checklist

When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments.

Thanks for taking care of this! We need this for the helm chart for sure!

src/go/k8s/README.md Show resolved Hide resolved
src/go/k8s/README.md Outdated Show resolved Hide resolved
src/go/k8s/config/e2e-test/manager.yaml Outdated Show resolved Hide resolved
src/go/k8s/kuttl-test.yaml Outdated Show resolved Hide resolved
src/go/k8s/config/manager/manager.yaml Show resolved Hide resolved
dimitriscruz
dimitriscruz previously approved these changes Feb 24, 2021
src/go/k8s/README.md Outdated Show resolved Hide resolved
src/go/k8s/README.md Outdated Show resolved Hide resolved
src/go/k8s/README.md Outdated Show resolved Hide resolved
src/go/k8s/config/manager/manager.yaml Show resolved Hide resolved
alenkacz
alenkacz previously approved these changes Feb 24, 2021
src/go/k8s/README.md Show resolved Hide resolved
dimitriscruz
dimitriscruz previously approved these changes Feb 24, 2021
alenkacz
alenkacz previously approved these changes Feb 24, 2021
Copy link
Contributor

@0xdiba 0xdiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultra nit: readme fix.
Just requesting changes since this already has approval and we do not want to merge :)

src/go/k8s/README.md Outdated Show resolved Hide resolved
@ivotron
Copy link
Member

ivotron commented Feb 24, 2021

hi all! quick question: regarding pushing the operator image to dockerhub, is it a matter of adding a step on the workflow that runs make push? if so, is the issue of choosing a versioning scheme the blocker for doing this?

First version of redpanda operator was released to docker hub.
This gives users ability to install operator without cloning
the repo.
@RafalKorepta
Copy link
Contributor Author

@ivotron The make push would only push the latest container tag. If we could have proper versioning scheme then I'm ok with adding additional step in github action.

I would like to move the versioning scheme problem to another place. #690

@mmaslankaprv mmaslankaprv merged commit 055926c into redpanda-data:dev Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants