-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator changes for local disk clusters #6942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7848052
to
adee505
Compare
adee505
to
a95b536
Compare
6 tasks
c5a01c3
to
3c18a1c
Compare
4ce5b9e
to
d3eaa14
Compare
0xdiba
reviewed
Nov 14, 2022
5153365
to
2b1b73a
Compare
RafalKorepta
approved these changes
Nov 15, 2022
/backport v22.3.x |
@joejulian Please fill out the backport section of the cover letter |
RafalKorepta
added a commit
to redpanda-data/redpanda-operator
that referenced
this pull request
Jun 19, 2024
Previous usage of finalizer handlers was unreliable in the case of flipping Kubernetes Nodes ready status. Local SSD disks that could be attached to Redpanda Pod prevents rescheduling as the Persistent Volume affinity bounds Pod to only one Node. In case of Kubernetes Node coming back to live Cluster controller could already delete Redpanda data (PVC deletion and Redpanda decommissioning). If particular Redpanda Node would host single replica partition, then it would be a data lost. If the majority of Redpanda process would run in unstable Kubernetes Nodes, then Redpanda operator could break whole cluster by losing Raft quorum. Reference #112 redpanda-data/redpanda#6942
RafalKorepta
added a commit
to redpanda-data/redpanda-operator
that referenced
this pull request
Jun 21, 2024
Previous usage of finalizer handlers was unreliable in the case of flipping Kubernetes Nodes ready status. Local SSD disks that could be attached to Redpanda Pod prevents rescheduling as the Persistent Volume affinity bounds Pod to only one Node. In case of Kubernetes Node coming back to live Cluster controller could already delete Redpanda data (PVC deletion and Redpanda decommissioning). If particular Redpanda Node would host single replica partition, then it would be a data lost. If the majority of Redpanda process would run in unstable Kubernetes Nodes, then Redpanda operator could break whole cluster by losing Raft quorum. Reference #112 redpanda-data/redpanda#6942
RafalKorepta
added a commit
to redpanda-data/redpanda-operator
that referenced
this pull request
Jun 21, 2024
Previous usage of finalizer handlers was unreliable in the case of flipping Kubernetes Nodes ready status. Local SSD disks that could be attached to Redpanda Pod prevents rescheduling as the Persistent Volume affinity bounds Pod to only one Node. In case of Kubernetes Node coming back to live Cluster controller could already delete Redpanda data (PVC deletion and Redpanda decommissioning). If particular Redpanda Node would host single replica partition, then it would be a data lost. If the majority of Redpanda process would run in unstable Kubernetes Nodes, then Redpanda operator could break whole cluster by losing Raft quorum. Reference #112 redpanda-data/redpanda#6942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
To support local disk, we need to use the automatic node id and automatic bootstrap, among other things. This is the start of that change.
Each additional body of work will be in its own commit, to make review easier.
Fixes #ISSUE-NUMBER, Fixes #ISSUE-NUMBER, ...
Backport Required
UX changes
Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.
Release notes