Explicitly deregister log metrics #8548
Conversation
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Even when the log is closed some of the user may still hold the log instance alive preventing metrics from being deregistred. Added explicit metrics deregistration when log is closed or removed. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-7983
branch
from
c8e4bbc
to
dd35d23
Compare
|
I think we might have seen this one in the field as well, so backporting to 22.3 |
|
/backport v22.3 |
|
/backport v22.3.x |
|
Oops! Something went wrong. |
|
Failed to run cherry-pick command. I executed the below command: |
|
Ooh this fixes https://github.com/redpanda-data/core-internal/issues/300? |
|
Backport: #8556 |
No idea, that ticket doesn't mention an assertion |
|
Sorry that is a dupe of https://github.com/redpanda-data/core-internal/issues/285 (which I think is #300 dupe)? |
|
ok, this PR is definitely not the same as #285 |
|
Are v22.2.x and v22.1.x not affected by this? |
|
They may well be, but this didn't strike me as severe enough (+ I think we may never have seen it on the field on older clusters) for the extra manual backports. |
Even when the log is closed some of the user may still hold the log
instance alive preventing metrics from being deregistred. Added explicit
metrics deregistration when log is closed or removed.
Fixes: #7983
Backports Required
UX Changes
Release Notes