Fix for "Expected quota value mismatch" failure in CDT and UTs #8623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some internal namespace functions are exposed via `kafka::detail` ns specifically for the tests. Tests include some specific cases and attempt for random driven generalization in the dispense_equally_test(). The latter also includes a specific value to reproduce redpanda-data#8613.
The minimum boundary for thoughput limit properties was originally `ss::smp::count` so that each shard would not get a zero default quota. Later that was changed to dynamic boundary control, while the static property minimum was changed to a constant `1` so that there is no situation when cluter properties replayed from the controller log were out of property bounds if smp::count on the node is different from the node where the configuration was made. However the change for kafka_throughput_limit_node_out_bps was left behind.
dlex
force-pushed
the
8613_quota-value-mismatch
branch
from
ea3ba07 to
459505e
Compare
|
Force push: sample numbers in |
|
CI Failure in https://buildkite.com/redpanda/redpanda/builds/22535#01861e0d-fc75-47d6-b63c-49c60f12f7e5:
|
dotnwat
approved these changes
Feb 7, 2023
graphcareful
approved these changes
Feb 7, 2023
| std::uniform_int_distribution<quota_t> dist( | ||
| bottomless_token_bucket::min_quota, bottomless_token_bucket::max_quota); | ||
|
|
||
| for (size_t shards_count = 1; shards_count != 65; ++shards_count) |
There was a problem hiding this comment.
nit: shards_count < 65
| @@ -464,10 +464,10 @@ void dispense_equally(std::vector<quota_t>& target, const quota_t value) { | |||
| v += share.quot; | |||
| if (share.rem > 0) { | |||
| v += 1; | |||
| share.quot -= 1; | |||
| share.rem -= 1; | |||
There was a problem hiding this comment.
could we write a unit test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8613
UTs are added for some specific cases with algorithm used internally by
snc_quota_manager. An attempt made for random driven generalization in the dispense_equally_test(). The latter also includes a specific value to reproduce #8613.Also tailgated is a tiny fix for the lower boundary of
kafka_throughput_limit_node_out_bpscluster property.Backports Required
UX Changes
Release Notes