Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.1.x] cloud_storage: fix "Leaving S3 objects behind" message #9407

Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 13, 2023

If tiered storage is disabled, we shouldn't print
this misleading message when not deleting objects.

Backport of #9405

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Bug Fixes

  • A spurious "Leaving S3 objects behind" log message is no longer printed when deleting non-tiered-storage partitions.

If tiered storage is disabled, we shouldn't print
this misleading message when not deleting objects.
@jcsp jcsp added kind/tech-debt area/cloud-storage Shadow indexing subsystem labels Mar 13, 2023
@jcsp jcsp changed the title cloud_storage: fix "Leaving S3 objects behind" message [v23.1.x] cloud_storage: fix "Leaving S3 objects behind" message Mar 14, 2023
@jcsp jcsp requested a review from abhijat March 14, 2023 12:32
@jcsp
Copy link
Contributor Author

jcsp commented Mar 14, 2023

@jcsp jcsp marked this pull request as ready for review March 14, 2023 12:33
@abhijat abhijat merged commit 85401df into redpanda-data:v23.1.x Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants