Remove cloud-specific topics from topic protection defaults #9453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
reviewed
Mar 21, 2023
src/v/config/configuration.cc
Outdated
| @@ -966,7 +966,7 @@ configuration::configuration() | |||
| "kafka_nodelete_topics", | |||
| "Prevents the topics in the list from being deleted via the kafka api", | |||
| {.needs_restart = needs_restart::no, .visibility = visibility::user}, | |||
| {"__audit", "__consumer_offsets", "__redpanda_e2e_probe", "_schemas"}) | |||
| {"__audit", "__consumer_offsets", "_schemas"}) | |||
There was a problem hiding this comment.
@graphcareful any implications on metering?
There was a problem hiding this comment.
Nope, metering has its own hardcoded list of topics:
static const auto usage_excluded_topics = std::to_array(
{model::topic("_schemas"),
model::topic("__audit"),
model::topic("__redpanda_e2e_probe")});
There was a problem hiding this comment.
So is this PR good to go, @dotnwat and @graphcareful ?
graphcareful
previously approved these changes
Apr 10, 2023
ballard26
force-pushed
the
remove-cloud-topics
branch
from
a3c6f88 to
f2a8d78
Compare
graphcareful
approved these changes
Apr 10, 2023
|
cc: @tcoupland and @bpraseed and @c4milo - we need cloud to propagate this property w/ the e2e probe. |
|
/backport v23.1.x |
|
@emaxerrno, it was done early on by @pvsune but we reverted due to the operator not being able to handle list of strings as value: https://github.com/redpanda-data/redpanda/blob/dev/src/go/k8s/apis/redpanda/v1alpha1/cluster_types.go#LL163C37-L163C44 |
|
was there an associated issue for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Cloud-specific internal topics from the internal topic protection defaults. This is mainly to enforce a separation of concerns as the Cloud team should be able to maintain their own set of defaults that are applied with k8s.
Backports Required
Release Notes