-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: make operator clusterscoped #9549
Conversation
src/go/k8s/Makefile
Outdated
@@ -6,7 +6,7 @@ CONFIGURATOR_IMG_LATEST ?= "localhost/configurator:dev" | |||
CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false" | |||
|
|||
# default redpanda image to load | |||
REDPANDA_IMG ?= "localhost/redpanda:dev" | |||
REDPANDA_IMG ?= "localhost/redpand-operator:dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RafalKorepta wanted to discuss this, as the make file makes little sense to me here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, what is the question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you build it usually builds the redpanda-operator, but the kustomize is set up to use the repanda:dev image, which makes no sense, was this intentional or is this an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REDPANDA_IMG is a placeholder for Redpanda container not operator. This is used in kuttle tests everywhere. It should point to the tip of the current branch that test run on. It should be used in the kind load docker-image only.
I personally don't use Makefile to load image to my cluster.
I pull latest nightly build from docker hub and I'm running kuttle test locally after retagging it to redpanda:dev
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
collectors: | ||
- type: pod | ||
selector: app.kubernetes.io/name=redpanda | ||
tail: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would not use collectors as this pollutes stdout of the kuttle cli, but it's very hard to find the root cause. I would advise to do something like:
redpanda/src/go/k8s/tests/e2e/update-image-tls/00-assert.yaml
Lines 59 to 70 in 8a9d43f
collectors: | |
- command: /bin/bash -c "mkdir -p ../../_e2e_artifacts/update-image-tls/step-0" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE get pods -o yaml > ../../_e2e_artifacts/update-image-tls/step-0/pods.yaml" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-0 -- curl -sk https://up-img-0.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/brokers > ../../_e2e_artifacts/update-image-tls/step-0/brokers-from-pod-0.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-1 -- curl -sk https://up-img-1.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/brokers > ../../_e2e_artifacts/update-image-tls/step-0/brokers-from-pod-1.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-2 -- curl -sk https://up-img-2.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/brokers > ../../_e2e_artifacts/update-image-tls/step-0/brokers-from-pod-2.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-0 -- curl -sk https://up-img-0.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/cluster_config/status > ../../_e2e_artifacts/update-image-tls/step-0/config-status-from-pod-0.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-1 -- curl -sk https://up-img-1.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/cluster_config/status > ../../_e2e_artifacts/update-image-tls/step-0/config-status-from-pod-1.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE exec -c redpanda up-img-2 -- curl -sk https://up-img-2.up-img.$NAMESPACE.svc.cluster.local.:9644/v1/cluster_config/status > ../../_e2e_artifacts/update-image-tls/step-0/config-status-from-pod-2.json" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE logs up-img-0 -c redpanda > ../../_e2e_artifacts/update-image-tls/step-0/logs-from-pod-0.txt" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE logs up-img-1 -c redpanda > ../../_e2e_artifacts/update-image-tls/step-0/logs-from-pod-1.txt" | |
- command: /bin/bash -c "kubectl -n $NAMESPACE logs up-img-2 -c redpanda > ../../_e2e_artifacts/update-image-tls/step-0/logs-from-pod-2.txt" |
I know it's painful to maintain the paths and names, but I didn't check the env vars during collectors. Maybe there is options to make collectors more generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thank you for that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It appears that |
And no k8s tests was run. If you could do rebase/commit rephrase or any other change that will trigger buildkite again, thanks |
Yes! I want to add a PR before this one and then rebase this one so that the Update tests are valid. PR I would like to merge first: #9641 |
f23ad10
to
eb61f86
Compare
81d3230
to
bcc7ac1
Compare
bc4fdbe
to
69c6652
Compare
fix: finished testing additions
69c6652
to
7c30c42
Compare
Closing and will reopen from a fork |
First run on making redpanda tests, a few issues also found and fixed.
Backports Required
Release Notes