Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case implementation example for JavaScript Validators #491

Merged
merged 4 commits into from
Oct 14, 2015
Merged

Conversation

yusuke
Copy link
Contributor

@yusuke yusuke commented Oct 6, 2015

test case implementation example for JavaScript Validators.
redpen.js : utlity script for testing JavaScript validators
validator-js-test.js : tests validator.js

$ mocha

*/
assert = require('assert');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is assert variable global?

I think that var assert = require('assert'); is better :)

$ ./redpen-server

3. rename validator.js.example to enable the validator implementation
$ cd $REDPEN_HOME/sample
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no sample directory in $REDPEN_HOME. js directory is correct.

@takahi-i
Copy link
Member

Thank you a lot for the contribution @yusuke as always! I have verified the changes are perfect! I just think the directory name does not exist in the REDPEN_HOME as I commented.

takahi-i added a commit that referenced this pull request Oct 14, 2015
test case implementation example for JavaScript Validators
@takahi-i takahi-i merged commit f713646 into master Oct 14, 2015
@takahi-i takahi-i deleted the js-test branch November 16, 2015 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants