Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic Korean support #849

Merged
merged 4 commits into from
Jun 23, 2019
Merged

Implement basic Korean support #849

merged 4 commits into from
Jun 23, 2019

Conversation

raccoonyy
Copy link
Contributor

Hello. I implemented basic Korean support for proofreading Korean. I referred to #568 and added Korean morphological analyzer Komoran as a dependency.

This P.R. based on @nacyot's #784 .

@takahi-i
Copy link
Member

takahi-i commented Jan 9, 2019

👍

@coveralls
Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage increased (+0.02%) to 91.403% when pulling 88db405 on raccoonyy:korean into 42a24bc on redpen-cc:master.

@takahi-i
Copy link
Member

@raccoonyy Thank you very much for the valuable contributeion! I will look into the changes.

@raccoonyy
Copy link
Contributor Author

@takahi-i Is there anything I can help?

@takahi-i
Copy link
Member

Deeply sorry for the late response... I will review this PR this weekend.

@raccoonyy
Copy link
Contributor Author

Thanks! 👍

@takahi-i
Copy link
Member

takahi-i commented Feb 2, 2019

I looked into the changes and confirmed the changes are great! Before the merge, is it possible to add the sample documents in several formats (such as markdown or asciidoc) 🙏 ?

The following is the directory of the samples, just we add the files (under ko) , which are copied into the final package and we can try redpen with the added sample documents.

https://github.com/redpen-cc/redpen/tree/master/redpen-cli/sample/sample-doc

@raccoonyy
Copy link
Contributor Author

I will add the docs soon. Thanks. :)

@raccoonyy
Copy link
Contributor Author

@takahi-i I added sample documents. I'm really sorry for the late.

nacyot and others added 4 commits June 12, 2019 15:03
* Add KOMORAN to pom.xml(korean morphological analyzer)
* Implement basic korean tokenizer
@takahi-i
Copy link
Member

Thank you very much @raccoonyy ! I will look into the changes this weekend.

@takahi-i
Copy link
Member

LGTM. Can you grant these changes under the Apache License 2.0 @raccoonyy?

@raccoonyy
Copy link
Contributor Author

@takahi-i Yes I do. :)

Do I have to modify the docs to grant Apache License 2.0?

@takahi-i
Copy link
Member

Thank you for the agreement @raccoonyy!

Do I have to modify the docs to grant Apache License 2.0?

Nothing. We just confirm it when large feature is proposed.

Thank you very much for the consistent work!

@takahi-i takahi-i merged commit 01608de into redpen-cc:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants