Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ForceDearu option + fixed MASU detection pattern #863

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

norm-ideal
Copy link
Contributor

I added the option to force the DEARU mode. Default mode is unchanged (auto-detection).

The original code determines if the document is in DEARU/DESUMASU by the superior occurrence, and it works in most cases. But many of our students write their report by using DESUMASU while it should be DEARU, so I needed to fix the mode to DEARU even when DESUMASU is superior.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.389% when pulling 6c8ba1b on norm-ideal:master into 42a24bc on redpen-cc:master.

@takahi-i takahi-i self-assigned this Jun 19, 2019
@takahi-i
Copy link
Member

@norm-ideal Thank you very much for the valuable contribution!

@takahi-i takahi-i merged commit f5499b7 into redpen-cc:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants