Make meta property optional
#76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2017 13:53
Update to v2.0.0 after potentially-breaking change to type definitions
|
Ah, sorry, I now see that this has been addressed before. I'll respectfully leave the PR open, because I think the interface definition for an "optional" property (as spec'ed in the docs) should allow the total omission of the property, if the user so desires. Forcing the presence of a property whose value is |
|
@linguamachina thank you for the PR. What do you think of the discussion in #53? To me it seems this question has a lot of back and forth... I'm not a daily TS user so I'm not sure what the best course going forward is. |
|
Closing in favour of #94. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the interface definition for
FluxStandardAction, making themetaproperty optional.