Fix remaining React 19 types compat issues

reduxjs · May 2, 2024 · a752cc6 · a752cc6
1 parent 23c0c22
commit a752cc6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/test/components/Provider.spec.tsx b/test/components/Provider.spec.tsx
@@ -169,7 +169,7 @@ describe('React', () => {
         action.type === 'INC' ? state + 1 : state
 
       const innerStore = createStore(reducer)
-      const innerMapStateToProps = vi.fn<TStateProps, [number]>((state) => ({
+      const innerMapStateToProps = vi.fn<[number], TStateProps>((state) => ({
         count: state,
       }))
       class Inner extends Component<TStateProps> {

diff --git a/test/typetests/connect-options-and-issues.tsx b/test/typetests/connect-options-and-issues.tsx
@@ -801,16 +801,17 @@ function testRef() {
     ref={(ref: number) => {}}
   ></ConnectedForwardedFunctionalComponent>
 
-  // Should be able to use all refs including legacy string
-  const classLegacyRef: React.LegacyRef<ClassComponent> | undefined = undefined
+  // Should be able to use all refs (except legacy string refs, which go away in React 19)
+  const classLegacyRef: React.Ref<ClassComponent> | undefined = undefined
   ;<ConnectedClassComponent ref={classLegacyRef}></ConnectedClassComponent>
   ;<ConnectedClassComponent
     ref={React.createRef<ClassComponent>()}
   ></ConnectedClassComponent>
   ;<ConnectedClassComponent
     ref={(ref: ClassComponent) => {}}
   ></ConnectedClassComponent>
-  ;<ConnectedClassComponent ref={''}></ConnectedClassComponent>
+  // TODO Can make this an expected error if we target React 19 exclusively
+  // ;<ConnectedClassComponent ref={''}></ConnectedClassComponent>
   // ref type should be the typeof the wrapped component
   ;<ConnectedClassComponent
     // @ts-expect-error