Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warnings in React >=16.3 #1410

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

samkline
Copy link

@samkline samkline commented Oct 1, 2019

Following up on #1407, there are two issues still causing warnings on the 5.x branch:

  • In development, componentWillUpdate is used. Even though this is dev-only, it causes verbose warnings that can mask other issues when working in a large project.
  • componentWillReceiveProps is incorrectly deleted from Connect's static properties, not from the prototype, so the delete is actually a no-op.

This PR addresses both issues. Thanks!

(This fixes an issue in an earlier PR I opened (#1409) -- I had gotten the lifecycle method wrong)

@timdorr
Copy link
Member

timdorr commented Oct 1, 2019

Cool, thanks!

@timdorr timdorr merged commit 2978315 into reduxjs:5.x Oct 1, 2019
@samkline samkline deleted the use-unsafe-lifecycle-methods-5.x branch October 2, 2019 20:55
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants