Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React 15 peerDependency to stable (15.0.1) #342

Closed
wants to merge 1 commit into from
Closed

Upgrade React 15 peerDependency to stable (15.0.1) #342

wants to merge 1 commit into from

Conversation

antoinerousseau
Copy link

Current issue:

$ npm i --save react@15

npm ERR! peerinvalid The package react@15.0.1 does not satisfy its siblings' 
peerDependencies requirements!
npm ERR! peerinvalid Peer react-redux@4.4.1 wants react@^0.14.0 || ^15.0.0-rc.1

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2016

The current range matches any 15.x release including 15.0.1.
Please refer to the official npm semver calculator:

screen shot 2016-04-09 at 00 08 58

You probably have issue due to some other package. npm just prints all of them rather than the one causing the problem, which is the common source of confusion.

@gaearon gaearon closed this Apr 8, 2016
@gaearon gaearon mentioned this pull request Apr 8, 2016
@antoinerousseau
Copy link
Author

Updated from NPM 2 to NPM 3 and this issue disappeared.

@antoinerousseau antoinerousseau deleted the react-15 branch April 8, 2016 23:15
@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2016

Hmm, weird. Could npm@2 have different behavior?

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2016

Are you sure this wasn’t an issue due to any other dependency?

@antoinerousseau
Copy link
Author

Well the error message is pretty explicit to me... here is the full output I got:

$ npm i --save react@15
npm ERR! Darwin 15.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "i" "--save" "react@15"
npm ERR! node v4.3.0
npm ERR! npm  v2.14.12
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package react@15.0.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer draft-js@0.3.0 wants react@^0.14.0 || ^15.0.0-rc
npm ERR! peerinvalid Peer material-ui@0.15.0-alpha.2 wants react@^0.14.0
npm ERR! peerinvalid Peer react-big-calendar@0.9.8 wants react@^0.14.0-beta1
npm ERR! peerinvalid Peer react-dnd@2.1.4 wants react@^0.14.0 || ^15.0.0-0
npm ERR! peerinvalid Peer react-dom@0.14.8 wants react@^0.14.8
npm ERR! peerinvalid Peer react-intl@2.0.0-rc-1 wants react@^0.14.0 || ^15.0.0-rc.1
npm ERR! peerinvalid Peer react-redux@4.4.1 wants react@^0.14.0 || ^15.0.0-rc.1
npm ERR! peerinvalid Peer react-tap-event-plugin@0.2.2 wants react@^0.14.0

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/antoine/Sites/mytribe-app/npm-debug.log

I read

The package react@15.0.1 does not satisfy its siblings' peerDependencies requirements!

followed by

react-redux@4.4.1 wants react@^0.14.0 || ^15.0.0-rc.1

Which to me means that react@^0.14.0 || ^15.0.0-rc.1 does not match react@15.0.1, but I could be wrong...

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2016

Yeah, this is why I said above:

You probably have issue due to some other package. npm just prints all of them rather than the one causing the problem, which is the common source of confusion.

The reason peer dependency check failed are these packages:

npm ERR! peerinvalid Peer react-big-calendar@0.9.8 wants react@^0.14.0-beta1
npm ERR! peerinvalid Peer react-dom@0.14.8 wants react@^0.14.8
npm ERR! peerinvalid Peer material-ui@0.15.0-alpha.2 wants react@^0.14.0
npm ERR! peerinvalid Peer react-tap-event-plugin@0.2.2 wants react@^0.14.0

The rest are fine, and once you fix those packages, the other lines won’t be there either. I know this is super confusing but that’s just the way npm@2.x works.

I verified this on a clean project here: #332 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants