Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DevTools, LogMonitor): prevent LogMonitor to render once as visible state #122

Closed
wants to merge 1 commit into from

Conversation

nikgraf
Copy link
Contributor

@nikgraf nikgraf commented Sep 20, 2015

I noticed that LogMonitor is rendered once, because isVisible is set to true in the initial state.
see https://github.com/gaearon/redux-devtools/blob/master/src/devTools.js#L89

In the LogMonitor the isVisible state was updated, but that will only affect the second render cycle. This is an issue in case you try to create a universal/isomorphic application with the same template.

screen shot 2015-09-20 at 19 54 08

I propose to fix it by updating the props optimistically. As an alternative we could do this case inside the LogMonitor. Let me know what you think 😄

@gaearon gaearon mentioned this pull request Sep 27, 2015
@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2015

Thanks for the PR! I'm closing because the way monitors currently manage their state isn't composable.
Please track the solution to this in next branch: #132 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants