Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightweight css animations for new actions entering the log. #57

Closed

Conversation

threepointone
Copy link
Contributor

while we ponder react-motion in #52, consider a simpler alternative for now :) this PR adds a css fadeIn animation to entries in the actions log.

@threepointone threepointone mentioned this pull request Aug 12, 2015
8 tasks
@nicinabox
Copy link
Collaborator

Would be awesome if you could show a gif of it!

@threepointone
Copy link
Contributor Author

it's quite subtle, doesn't show well (and seems longer) in this gif http://recordit.co/ss6t7FyU7H :|

@nicinabox
Copy link
Collaborator

Nice! What happens when you get down to the bottom and it starts scrolling?

@threepointone
Copy link
Contributor Author

just adds it at the bottom as it already does now, along with the subtle fade. try it, it's really not much :)

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

I'll defer any visual decisions to @nicinabox to approve

@nicinabox
Copy link
Collaborator

How do we feel about the flash? For reference:

fade mov

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

What if we do the opposite? Start off actions brighter than usual, then let them “cool down”. Like changing nodes in Chrome inspector.

@nicinabox
Copy link
Collaborator

That's a neat effect too. I think the biggest thing that's lacking with each of these is you don't really see the content move upwards (but these are still an improvement).

flash mov

@dzannotti
Copy link
Collaborator

i like all 3

@nicinabox
Copy link
Collaborator

Oops, probably wasn't clear on the first one. It's @threepointone's. I just recorded at 30fps and showed scrolling.

@nicinabox
Copy link
Collaborator

Could we append it then animate scrolling to the bottom?

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

Yeah. Let's replace naïve scrolling with something like https://github.com/alexkuz/additive-animation#usage-example?

@gaearon
Copy link
Contributor

gaearon commented Sep 24, 2015

Closing, as I don't currently have time to make it better, and scrolling seems to be important for the desired effect. If someone would like to implement it, please do it in https://github.com/gaearon/redux-devtools-log-monitor instead (track #132 for discussion).

@gaearon gaearon closed this Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants