-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettier #262
Add Prettier #262
Conversation
I'll be honest and say I really am not fond of the "conventional commit" format. In addition, I don't think we want to do a release every time there's a merge to master. I would be potentially interested in more of a "push-button" automation for our Redux package releases in general, but this seems like more than I'd like added atm. Is this something of a drive-by PR, or was this discussed with @timdorr at some point? |
Drive-by 🚗 😆 I noticed a conventional commit in the commit history is all. Happy to modify the PR as needed. |
Not sure how to automate the package versions w/o conventional commits though. |
Perhaps something like this? https://github.com/sindresorhus/np |
Yeah, can we break this out into individual PRs? Adding Prettier is definitely worth its own commit. |
Just removed anything related to semantic release or conventional commits. |
And yes, I myself use |
I prefer the handcrafted, vintage, artisanal |
Thanks for the quick turnaround! The inconsistent semis and quotes was bugging me 😄 |
Speaking of publishing, it's been a year since redux-thunk's last release. When can I expect to get my hands on a published version of #260? I really need it to fix a TS hole in Redux Starter Kit. |
I can poke at it soon. It may be Monday, as I'm occupied by Dragon Con this weekend. |
Thanks and let me know if you need any help with anything TypeScript related. I just saw reduxjs/redux#3536. |
Actually, check out reduxjs/redux#3500 for the full details. |
Uses the following libraries to make this repo more contributor-friendly:
Making your repo Commitizen-friendlySemantic ReleaseAutomatic npm/GitHub release📦 ⬆️This PR (if merged into master) and any future PRs merged directly into master will trigger an npm & GitHub release + changelog. This is done via@jedmao/semantic-release-npm-github-config
, as mentioned in Semantic Release Community Configurations.This was done in an effort to make maintenance and releases less of a burden to maintainers.😀 ❤️
Important!🚨Before merging this PR (if you so decide), ensure that the following secret environment variables are set in your Travis-CI settings:GH_TOKEN
withpublic_repo
access.NPM_TOKEN