fix CaseReducer to infer from argument, not return value

reduxjs · Jan 2, 2023 · 8beef87 · 8beef87
1 parent 6a7879f
commit 8beef87
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/toolkit/src/createReducer.ts b/packages/toolkit/src/createReducer.ts
@@ -55,7 +55,7 @@ export type ActionMatcherDescriptionCollection<S> = Array<
 export type CaseReducer<S = any, A extends Action = AnyAction> = (
   state: Draft<S>,
   action: A
-) => S | void | Draft<S>
+) => NoInfer<S> | void | Draft<NoInfer<S>>
 
 /**
  * A mapping from action types to case reducers for `createReducer()`.

diff --git a/packages/toolkit/src/tests/createSlice.typetest.ts b/packages/toolkit/src/tests/createSlice.typetest.ts
@@ -59,21 +59,22 @@ const value = actionCreators.anyKey
       increment: (state: number, action) => state + action.payload,
       decrement: (state: number, action) => state - action.payload,
     },
-    extraReducers: {
-      [firstAction.type]: (state: number, action) =>
-        state + action.payload.count,
+    extraReducers: (builder) => {
+      builder.addCase(
+        firstAction,
+        (state, action) => state + action.payload.count
+      )
     },
   })
 
   /* Reducer */
 
-  const reducer: Reducer<number, PayloadAction> = slice.reducer
+  expectType<Reducer<number, PayloadAction>>(slice.reducer)
 
   // @ts-expect-error
-  const stringReducer: Reducer<string, PayloadAction> = slice.reducer
+  expectType<Reducer<string, PayloadAction>>(slice.reducer)
   // @ts-expect-error
-  const anyActionReducer: Reducer<string, AnyAction> = slice.reducer
-
+  expectType<Reducer<string, AnyAction>>(slice.reducer)
   /* Actions */
 
   slice.actions.increment(1)