Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTK Query Migration] Migrate RTKQ source and docs files to this repo #963

Closed
markerikson opened this issue Mar 30, 2021 · 5 comments
Closed
Milestone

Comments

@markerikson
Copy link
Collaborator

Once we're happy with the final RTKQ alpha status, we need to port all of the source and docs files over here into this git repo.

Ideally, I want all the source files to end up in src/query/ and the docs in docs/query.

I also want to preserve the Git history of all those files.

This may require running the RTKQ repo through a clone + filter-branch-style reprocessing, to create a new repo with the same names. Alternately, we could make a clone, then move the files in that repo and detect renames.

Either way, after that we pull the RTKQ branch over here and merge in with an "allow-unrelated" to get the files to combine together.

@hardfist
Copy link
Contributor

so rtkq will not be a standalone package?

@markerikson
Copy link
Collaborator Author

Nope, that's the whole point of the "extra entry points" thing I asked you to set up :)

We want RTKQ to be directly included in the @reduxjs/toolkit package on NPM - no other packages to install.

But, since it's a good chunk of extra logic, we want to ensure that you only pay for those bytes if you actually need them, and we need to provide both "vanilla JS" and "React-specific" versions of createApi, so that people who want to use createApi with Angular or Vue or Svelte aren't fighting with having to add dependencies on React too.

@hardfist
Copy link
Contributor

its a pity that you dont have a chance to fight monorepo beast

@markerikson
Copy link
Collaborator Author

Hah, nice way to put it :)

I've debated putting all the Redux projects (Redux, React-Redux, RTK) into a monorepo, mostly to enable having a single combined docs site. But, that would be a ton of effort, and I don't see enough benefit right now. (Besides, we've got wayyyy too many other things to work on right now.)

@markerikson
Copy link
Collaborator Author

First steps resolved by #1006 and #1007 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants