-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTK Query Migration] Fill out remaining not-yet-covered RTKQ docs content #964
Comments
Primary migration work was done in #1015 . Going to leave this open to cover fleshing out the rest of the missing content. |
Missing pieces from discussion:
|
Just so it doesn't get missed: The 'bailing out of errors' section on 'Error Handling' is still TODO also: https://deploy-preview-1016--redux-starter-kit-docs.netlify.app/usage/rtk-query/error-handling#bailing-out-of-errors |
Per a user:
|
Both the "bailing out of errors" section & "Need to cover how to use a custom base query" are intended to be covered by #1057 |
Intended to be covered by #1060 |
This is intended to be covered by #1066 |
I don't see any information on how the cached data lifetime + subscriptions behavior works. I wrote up a Reddit comment describing it: https://www.reddit.com/r/reactjs/comments/nej4sv/redux_to_store_a_lot_of_data/gykyzms/ |
Navigating to RTK Query For example, if looking for what the generated react hooks return (IMO likely to be one of the higher traffic sections), you need to:
React Hooks link location in sidebar @markerikson what are your thoughts on shifting them out somewhere higher to reduce nesting? |
@markerikson we have this currently: https://deploy-preview-1016--redux-starter-kit-docs.netlify.app/usage/rtk-query/cached-data#default-cache-handling-behaviour But I think your explanation was very handy, so I've merged it together with the existing description under #1071 |
Obligatory Twitter poll to get feedback on the docs organization: |
@markerikson Perhaps by ignoring the type definitions, the documentation can be made more readable. |
Yeah, if we do have typedefs in the "Usage" pages, those need to be moved to the relevant API ref pages (and the "Usage" pages should probably link over to the API refs as appropriate). |
Regarding typedefs in the usage pages, please see the proposed updated version from #1074 the changes would still keep the 'Query hook return types' in the Each of the two pages is proposed to also include a line linking to their respective API pages like:
Please let me know your thoughts if you think this is still too much type information for the 'Usage' pages https://deploy-preview-1074--redux-starter-kit-docs.netlify.app/usage/rtk-query/queries#query-hook-return-types |
Hmm. Just out of curiosity, could we limit it to the 5-ish most frequently used fields just to keep it short here? Also, would it be easier to read the descriptions if they were bullet points after the code block, instead of inline comments? |
FWIW, the Twitter poll is leaning towards having a single top-level "RTK Query" section. (Small sample size, etc, but FYI.) |
We need to actually describe how to use |
Also some examples of |
Both of the above are intended to be covered by #1081 |
Intended to be covered by #1119 |
Final bits of cleanup work:
|
Gonna say this is good to go :) |
Depends on #963 .
Once the RTKQ source/docs content is in this repo, we need to update the RTK docs to include that info. My plan is:
RTK Query
subcategory under "API Reference", withcreateApi
and friendsCould also argue it should be its own top-level section in some way (maybe just the "Concepts" material, but not the API reference?)
We'll need to emphasize that this is all exported by the new
"@reduxjs/toolkit/query"
and"@reduxjs/toolkit/query/react"
entry points, not the main"@reduxjs/toolkit"
entry point.This should probably be done on a 1.6 integration branch so that we don't publish it too early.
The text was updated successfully, but these errors were encountered: