Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - add usage with typescript page #1088

Conversation

Shrugsy
Copy link
Collaborator

@Shrugsy Shrugsy commented May 25, 2021

Related to #964

Adds a usage with typescript page.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5da6577:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@netlify
Copy link

netlify bot commented May 25, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 5da6577

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60b044f72a2df70008f57a1a

😎 Browse the preview: https://deploy-preview-1088--redux-starter-kit-docs.netlify.app

@Shrugsy Shrugsy force-pushed the docs/add-usage-with-typescript-page branch 2 times, most recently from 3bc4d57 to da6c79e Compare May 25, 2021 14:29
@Shrugsy
Copy link
Collaborator Author

Shrugsy commented May 25, 2021

RFC: Is this location in the sidebar appropriate, or would this page warrant being up one level, in line with RTK Query Overview and Comparison with Other Tools?

image

@Shrugsy
Copy link
Collaborator Author

Shrugsy commented May 25, 2021

RFC: Can anyone think of anything else missed that should be covered on this page?

@Shrugsy Shrugsy force-pushed the docs/add-usage-with-typescript-page branch from da6c79e to a175b27 Compare May 27, 2021 07:37
@Shrugsy Shrugsy changed the title [DRAFT] - Docs - add usage with typescript page Docs - add usage with typescript page May 27, 2021
@Shrugsy Shrugsy marked this pull request as ready for review May 27, 2021 07:37
@markerikson
Copy link
Collaborator

I'm actually going to say we maybe oughta move it up to the upper level.

I know that's a bit inconsistent in terms of "usage" location with our page for the RTK core (and even the Redux core), but given how many people will likely want to use RTKQ + TS together, I'd rather not have it buried in the middle of the other pages.

@markerikson markerikson merged commit ac01979 into reduxjs:feature/v1.6-integration May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants