prevent badly typed Middleware<any> from casting dispatch to any
#1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f43d05:
|
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 5f43d05 https://deploy-preview-1041--redux-starter-kit-docs.netlify.app |
phryneas
force-pushed
the
guard-dispatch-from-any
branch
2 times, most recently
from
0ed73f5
to
29ba8e0
Compare
|
merging this after #1034 should also fix those type tests |
phryneas
force-pushed
the
guard-dispatch-from-any
branch
from
29ba8e0
to
5f43d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened to myself: had a cast to
Middleware<any>somewhere in the tests and suddenly all ourdispatchwereany, too. We should catch that.