-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove originalArgs
from the mutation slice
#1318
Conversation
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: d87c248 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60f3187ad7ab5c000899286d 😎 Browse the preview: https://deploy-preview-1318--redux-starter-kit-docs.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d87c248:
|
size-limit report 📦
|
Yeah, fine by me. What else do we need before merging? |
originalArgs
from the store for mutationsoriginalArgs
from the mutation slice
Fixes #1209 #1315
This needs a few more tests and we should generally discuss how we communicate it:
Technically, it is a breaking change (removes a store property what would have been returned by a selector), but it is a necessary bugfix.
Generally, the information removed is still available as
dispatch
so it has very little impact.
Are we okay putting this out as a patch release @markerikson?