Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove originalArgs from the mutation slice #1318

Merged
merged 3 commits into from
Jul 17, 2021

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jul 17, 2021

Fixes #1209 #1315

This needs a few more tests and we should generally discuss how we communicate it:

Technically, it is a breaking change (removes a store property what would have been returned by a selector), but it is a necessary bugfix.

Generally, the information removed is still available as

  • property on the promise returned by dispatch
  • part of the thunk action meta
  • return value of the thunk (I could keep that using the promise approach described above)

so it has very little impact.

Are we okay putting this out as a patch release @markerikson?

@netlify
Copy link

netlify bot commented Jul 17, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: d87c248

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60f3187ad7ab5c000899286d

😎 Browse the preview: https://deploy-preview-1318--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d87c248:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

@github-actions
Copy link

github-actions bot commented Jul 17, 2021

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.2 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.23 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 20.31 KB (-0.04% 🔽)
1. entry point: @reduxjs/toolkit/query (esm.js) 17.36 KB (-0.03% 🔽)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 22.16 KB (+0.21% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 19.78 KB (+0.18% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.54 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.52 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 9.2 KB (-0.06% 🔽)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 9.57 KB (-0.06% 🔽)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.33 KB (+2.59% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.17 KB (+2.4% 🔺)
3. createSlice (esm.js) 5.16 KB (0%)
3. createEntityAdapter (esm.js) 5.2 KB (0%)
3. configureStore (esm.js) 5.21 KB (0%)
3. createApi (esm.js) 15.64 KB (-0.05% 🔽)
3. createApi (react) (esm.js) 17.99 KB (+0.15% 🔺)
3. fetchBaseQuery (esm.js) 10.92 KB (0%)
3. setupListeners (esm.js) 9.79 KB (0%)
3. ApiProvider (esm.js) 16.93 KB (-0.05% 🔽)

@phryneas phryneas mentioned this pull request Jul 17, 2021
@phryneas phryneas added this to the 1.6.1 milestone Jul 17, 2021
@markerikson
Copy link
Collaborator

Yeah, fine by me. What else do we need before merging?

@phryneas phryneas marked this pull request as ready for review July 17, 2021 22:29
@phryneas phryneas changed the title remove originalArgs from the store for mutations remove originalArgs from the mutation slice Jul 17, 2021
@phryneas phryneas merged commit b9246eb into master Jul 17, 2021
@phryneas phryneas deleted the pr/remove-mutation-originalArgs branch July 17, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Expose tools to make our own normalized query
2 participants