Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve cloned response in parallel in fetchBaseQuery #1452

Closed
wants to merge 1 commit into from

Conversation

GU5TAF
Copy link

@GU5TAF GU5TAF commented Aug 29, 2021

Fixes #1451

@netlify
Copy link

netlify bot commented Aug 29, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 046d3c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/612b81182d04a00007284e87

😎 Browse the preview: https://deploy-preview-1452--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 046d3c4:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
fetchBaseQuery broken with node-fetch Issue #1451

@phryneas
Copy link
Member

Thanks for the PR! This has already been solved over in #1277 (with be2dbb7 ), which also adds some other changes to fetchBaseQuery, so this change would probably result in a merge error and mostly be removed after merge of that PR.

So I'm gonna close this one, I hope that doesn't discourage you from future PRs.

Sorry you had to go down this rabbit hole. I know from personal experience how frustrating that bug is.

Until we release the next version, you can use the CodeSandbox build of this PR - it will stay around. Also, if you are in a SSR environment, feedback in #1277 would be great :)

@phryneas phryneas closed this Aug 29, 2021
@GU5TAF
Copy link
Author

GU5TAF commented Aug 29, 2021

Ah, I skimmed that PR but missed that it had been addressed 🤦‍♂️ Happy to hear it's being fixed, it was indeed a frustrating evening of wondering why fetch wasn't working 😅

@phryneas
Copy link
Member

Yeah, that cost me about two days I believe 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetchBaseQuery does not work with node-fetch due to usage of response.clone()
2 participants