-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action listener middleware to cover additional use cases #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use ThunkDispatch as the default type
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2dd9d01:
|
a83d884
to
e97a03a
Compare
e97a03a
to
2dd9d01
Compare
Ignoring the docs failure - another "can't find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the action listener middleware based on the changes proposed in #1648 (reply in thread) :
type: "module"
line from the listener middlewarepackage.json
file to avoid unwanted ESM handlingmatcher
andactionPredicate
listener overloadsMap<idString, ListenerEntry>
stopPropagation
methodWhen
values to'beforeReducer'
and'afterReducer'
, and adds an additional'both'
valuetry/catch
to handle errorsextra
value ala thunks, but without good typinggetOriginalState
method that captures the state before the action was dispatchedcondition
method to enable long-running async workflows, based on https://docs.temporal.io/docs/typescript/workflows/#conditionFor any review, please focus on actual code per intent - let's save the bikeshedding for the discussion thread after I get an updated alpha release out :)