-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra
to prepareHeaders
, update documentation + tests
#1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
changed the title
Document missing properties on prepareHeaders signature
Document missing properties on Jan 15, 2022
prepareHeaders
signature
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ec81a5:
|
size-limit report 📦
|
msutkowski
changed the title
Document missing properties on
Add Jan 22, 2022
prepareHeaders
signatureextra
to prepareHeaders
, update documentation + tests
msutkowski
force-pushed
the
prepareHeaders-docs
branch
3 times, most recently
from
January 23, 2022 00:58
9233c13
to
fb478e3
Compare
msutkowski
force-pushed
the
prepareHeaders-docs
branch
from
January 23, 2022 04:38
fb478e3
to
2ec81a5
Compare
phryneas
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoint
,type
,forced
, andextra
are passed through toprepareHeaders
extra
toprepareHeaders
🎉