Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(4058): operation parameter should override pathItem parameters #4084

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

julien-tricent
Copy link
Contributor

This fix #4058

Copy link

codesandbox bot commented Jan 16, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 2bc959a
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/66d23c047e8f8e0008faa8fc
😎 Deploy Preview https://deploy-preview-4084--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Jan 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bc959a:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@juliengbt
Copy link
Contributor

@EskiMojo14 Can I get you to have a look at that ? :)

@EskiMojo14
Copy link
Collaborator

as a general rule i try to avoid reviewing codegen PRs solely because i've never used OpenAPI before

with that said, the changes and tests make sense to me

can you resolve the conflicts?

# Conflicts:
#	packages/rtk-query-codegen-openapi/src/generate.ts
@markerikson
Copy link
Collaborator

Thanks!

@markerikson markerikson merged commit be6f9a6 into reduxjs:master Aug 30, 2024
15 of 16 checks passed
@juliengbt
Copy link
Contributor

@tricent-lvi

@markerikson
Copy link
Collaborator

Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question/Feature (@rtk-query/codegen-openapi): Support for overriding path-level parameters at operation Level
4 participants