Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expectExactType to be compatible with TypeScript 5.4 #4121

Closed
wants to merge 4 commits into from

Conversation

aryaemami59
Copy link
Contributor

This PR:

Copy link

codesandbox bot commented Jan 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 6c7c165
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/65b47a8538180e00099ae4ec
😎 Deploy Preview https://deploy-preview-4121--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Jan 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c7c165:

Sandbox Source
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14
Copy link
Collaborator

Hmm, the removal of the ts-expect-error comments worries me - those should be errors.

I've commented over at reduxjs/react-redux#2123.

@aryaemami59
Copy link
Contributor Author

Hmm, the removal of the ts-expect-error comments worries me - those should be errors.

I've commented over at reduxjs/react-redux#2123.

Not sure if this counts as a fix but Here I've replaced expectExactType with some of Vitest's type test utilities.

@EskiMojo14
Copy link
Collaborator

EskiMojo14 commented Jan 25, 2024

yeah, as long as those vitest utilities don't break in 5.4, and we can get the same functionality, i think it would be worth looking into switching our type tests to vitest style ones at some point

edit: raised #4122

@aryaemami59
Copy link
Contributor Author

Closing in favor of #4127

@aryaemami59 aryaemami59 deleted the fix-expectExactType branch January 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants