-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expectExactType
to be compatible with TypeScript 5.4
#4121
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c7c165:
|
Hmm, the removal of the ts-expect-error comments worries me - those should be errors. I've commented over at reduxjs/react-redux#2123. |
Not sure if this counts as a fix but Here I've replaced |
yeah, as long as those vitest utilities don't break in 5.4, and we can get the same functionality, i think it would be worth looking into switching our type tests to vitest style ones at some point edit: raised #4122 |
Closing in favor of #4127 |
This PR:
expectExactType
to be compatible with TypeScript 5.4 per MoveEquals
constraint into an intersection type. react-redux#2123