-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support default return schemas in openapi codegen #4145
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7928634:
|
Could you please add a test that shows a schema with this and the resulting generated code? |
I have added a test, but for some reason I can't run it locally. I get weird errors unrelated to test itself.
not sure I am doing wrong I just tried to do:
|
codegen tests are currently broken after updating node-fetch (which is now ESM only, it seems) - #4137 is an attempt to fix it long term by migrating to vitest but we might just need to revert the node-fetch update in the meantime |
merged in #4151 to temporarily revert back to node-fetch v2, try now |
I have fixed the tests. This adds |
The extra void was removed, it was a bug in the filter that removes all "void" from possible types. |
Accidently closed this, reopened in #4152 |
According to https://swagger.io/docs/specification/describing-responses/#default this is a valid way to describe a possible response.