allow to skip AsyncThunks using a condition callback #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 5b2fa9a https://deploy-preview-513--redux-starter-kit-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b2fa9a:
|
markerikson
requested changes
Apr 19, 2020
src/createAsyncThunk.ts
Outdated
| if ( | ||
| options && | ||
| options.condition && | ||
| !options.condition(arg, { getState, extra }) |
There was a problem hiding this comment.
I think we should make this a strict === false comparison. The user might return undefined or falsy by accident. The assumption should be that the thunk is going to run unless they really say no.
markerikson
force-pushed
the
asyncThunkCondition
branch
from
1493609
to
9294b14
Compare
phryneas
force-pushed
the
asyncThunkCondition
branch
from
9294b14
to
2647666
Compare
markerikson
force-pushed
the
asyncThunkCondition
branch
from
2647666
to
9294b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at adding a
conditioncallback so that people can skipasyncThunkexecution before it even enterspendingstate, depending onarg,getState()andextra.(Please don't merge this before #502 and #512, I guess order of merging might be of importance for merge conflicts here 😆)