Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export original from immer #832

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

jackielii
Copy link
Contributor

fixes #829

@netlify
Copy link

netlify bot commented Dec 3, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit e5d21f2

https://deploy-preview-832--redux-starter-kit-docs.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit cb94161

https://deploy-preview-832--redux-starter-kit-docs.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit 27ed75a

https://deploy-preview-832--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27ed75a:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@jackielii
Copy link
Contributor Author

hmm, the pipeline failing, but seems not related to this PR:

FAIL type-tests/types.test.ts (45.576s)
  ✕ Types (43152ms)

  ● Types

    Semantic: /home/runner/work/redux-toolkit/redux-toolkit/src/index.ts (8, 3) Module '"../node_modules/immer/compat/pre-3.7/dist/immer"' has no exported member 'freeze'.

@phryneas
Copy link
Member

phryneas commented Dec 3, 2020

Yes and no.
This segment should add an // @ts-ignore before running the tests in old TS versions.

https://github.com/reduxjs/redux-toolkit/blob/master/.github/workflows/tests.yml#L72-L76

Maybe the export changed there now?

@jackielii
Copy link
Contributor Author

@phryneas thanks for the tip. I believe it's now passing except for the same error from master

@phryneas phryneas changed the base branch from master to next December 4, 2020 18:57
@phryneas
Copy link
Member

phryneas commented Dec 4, 2020

Yeah, Travis is just failing because we want to remove that soon anyways and I didn't update anything there ;)

I'll merge this into the next branch. Thank you!

@phryneas phryneas merged commit f7c5e5a into reduxjs:next Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare original state with reference equality
3 participants