-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simpler unwrapping of createAsyncThunk promises #970
Conversation
Deploy preview for redux-starter-kit-docs ready! Built with commit 2563cb6 https://deploy-preview-970--redux-starter-kit-docs.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2563cb6:
|
Hmm. @hardfist , for some reason I'm seeing this failure in the CI action , at https://github.com/reduxjs/redux-toolkit/pull/970/checks?check_run_id=2242739748 :
Strictly speaking, the Any idea why we might be having an issue there? |
* Regen package-lock * Drop ignore-scripts flag * Set NODE_ENV on pack
Size Change: +211 B (0%) Total Size: 84.9 kB
ℹ️ View Unchanged
|
oh esbuild currently doesnt support npm7 because of npm bug |
you may need to use npm@6 before bug fixed |
Apparently the issue was just that we had |
i never expect this :) |
This PR:
.unwrap()
function attached to promises returned fromcreateAsyncThunk
master
, since they went intonext
Fixes #775, fixes #910 .