Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

an unnecessary argument in applyMiddleware.js #2131

Closed
HQidea opened this issue Nov 30, 2016 · 1 comment
Closed

an unnecessary argument in applyMiddleware.js #2131

HQidea opened this issue Nov 30, 2016 · 1 comment

Comments

@HQidea
Copy link

HQidea commented Nov 30, 2016

Since there is no enhancer argument passed to an enhancer, so this argument can be omitted.

see: https://github.com/reactjs/redux/blob/master/src/applyMiddleware.js#L20

If this is ok, I'll send a pr later.
@jimbolla
Copy link
Contributor

Duplicate: #2128 (comment)

@jimbolla jimbolla mentioned this issue Jan 12, 2017
Merged
timdorr pushed a commit that referenced this issue Oct 6, 2017
@jimbolla @timdorr
Refactors applyMiddleware to reduce confusion around createStore args. (
b30e6ae 
#2201)

Because #2200 #2131#2128 #2028...
seantcoyote pushed a commit to seantcoyote/redux that referenced this issue Jan 14, 2018
@jimbolla @seantcoyote
Refactors applyMiddleware to reduce confusion around createStore args. (
ecda836 
reduxjs#2201)

Because reduxjs#2200 reduxjs#2131#2128 reduxjs#2028...
@Methuselah96 Methuselah96 mentioned this issue May 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimbolla @HQidea