Warn When dispatching During Middleware Setup #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| * To ensure that you may only apply middleware once, it operates on `createStore()` rather than on `store` itself. Instead of `(store, middlewares) => store`, its signature is `(...middlewares) => (createStore) => createStore`. | ||
|
|
||
| Because it is cumbersome to apply functions to `createStore()` before using it, `createStore()` accepts an optional last argument to specify such functions. | ||
|
|
||
| #### Caveat: Dispatching During Setup | ||
|
|
||
| While `applyMiddleware` sets up your middleware, the `store.dispatch` function will point to the vanilla version provided by `createStore`. None of the other middleware will be applied to this `dispatch` until after setup is complete. If you are expecting an interaction with another middleware during setup, you will probably be disappointed. Instead, you should either communicate directly with that other middleware via a common object (for an API calling middleware, this may be your API client object) or waiting until after the middleware is constructed with a callback. |
|
All set. |
timdorr
added a commit
that referenced
this pull request
Jan 5, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Apr 25, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Oct 22, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Oct 22, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Oct 23, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Nov 3, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
timdorr
added a commit
that referenced
this pull request
Nov 16, 2017
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
tomipaul
pushed a commit
to tomipaul/redux
that referenced
this pull request
Apr 8, 2018
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates #1345
Closes #1240
Switched this to throw an error now.