Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use subscribe to persist to localStorage #1620

Merged
merged 2 commits into from May 3, 2016
Merged

use subscribe to persist to localStorage #1620

merged 2 commits into from May 3, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2016

more discoverable than #1608

@gaearon
Copy link
Contributor

gaearon commented Apr 21, 2016

The wording is not entirely what I wanted. Maybe something like this?

You can use subscribe() to update the UI in response to state changes.
Normally you’d use a view binding library (e.g. React Redux) rather than subscribe() directly.
However it can also be handy to persist the current state in the localStorage.

@gaearon gaearon mentioned this pull request Apr 21, 2016
@ghost
Copy link
Author

ghost commented Apr 21, 2016

Yep, yours is clearer.

@gaearon
Copy link
Contributor

gaearon commented Apr 21, 2016

Feel free to use it in your PR or tweak it. It’s your initiative, I’m just trying to be helpful. 😉

@ghost
Copy link
Author

ghost commented May 3, 2016

Did I do it right? (I've never done more than one commit on a branch for a PR.)

@gaearon gaearon merged commit b8f3662 into reduxjs:master May 3, 2016
@gaearon
Copy link
Contributor

gaearon commented May 3, 2016

Yep, thanks!

@ghost ghost deleted the patch-2 branch May 3, 2016 19:24
seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
* use subscribe to persist to localStorage

more discoverable than reduxjs#1608

* Clearer wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant