Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1632 when a new dep messed up the syntax for ES3 compatibility.
This small tool won't ensure IE8 compat, but it will throw if the syntax is unsupported. In practice, this means consumers can exclude a module with a runtime flag, instead of messing with it at build time.
The current version failed for the minified umd build, as
default
was unquoted in property access, so I removedscrew_ie8
option.A screenshot of sample output on mismatch (this is the minified file before the change to uglify). (the diff is just before and after
es3ify
with some color)I added the check to
prepublish
and not the linting as the code has to have been built before the check can be run. Might be annoying if tags have been made and such, but unsure if it's better to have it somewhere else?