Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect to devDependencies to run tests #1721

Merged
merged 1 commit into from
May 13, 2016
Merged

Add expect to devDependencies to run tests #1721

merged 1 commit into from
May 13, 2016

Conversation

jiayihu
Copy link
Contributor

@jiayihu jiayihu commented May 12, 2016

expect package is missing from devDependencies and it's required to run tests in this example.

`expect` package is missing from devDependencies and it's required to run tests in this example.
@gaearon
Copy link
Contributor

gaearon commented May 12, 2016

Are any other examples missing dependencies? Can you delete node_modules in the root directory and verify that all other examples work fine with just their own node_modules?

@jiayihu
Copy link
Contributor Author

jiayihu commented May 12, 2016

I didn't have node_modules installed in root because I was interested only in the examples :D Anyway I checked npm start and npm test whenever possible, tried also to play around with all the examples and none of them report errors in terminal or browser console ✅

@gaearon gaearon merged commit afffc26 into reduxjs:master May 13, 2016
@gaearon
Copy link
Contributor

gaearon commented May 13, 2016

Thank you!

@jiayihu jiayihu deleted the patch-1 branch May 13, 2016 20:06
seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
`expect` package is missing from devDependencies and it's required to run tests in this example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants