-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm tasks #267
npm tasks #267
Conversation
How does making a Github release fit into this workflow? Should I just do a release via web interface separately based on the pushed tag? |
When you do a release, a github tag is created. Then you need to manually create the release note for that existing tag (but that's always a manual process). Or do you mean something else? |
Yeah this seems right. This looks great to me. |
@@ -0,0 +1,9 @@ | |||
{ | |||
"commitMessage": "Bumps to version v%s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just change it to %s
please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Cool 👍 One thing though to remember: the patch/minor/major tasks work for normal semver numbers, so normal lifecycle releases. |
Oh, okay, thanks for explaining. |
5b9b25c
to
9617cb0
Compare
@gaearon ok, I made the changes and force pushed. Should be ok now. |
@@ -0,0 +1,9 @@ | |||
{ | |||
"commitMessage": "Bumps to version %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just %s please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought vs%
without v
. Will change it, sorry
"commitMessage": "Bumps to version %s", | ||
"tagName": "v%s", | ||
"scripts": { | ||
"preupdate": "npm test && npm run umd", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not build it as part of npm run build
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The umd
part? Makes sense!
@gaearon feel free to do the final tweaks the way you like it ;) |
Sure, thanks! I'll actually use some of these for a boilerplate I'm preparing. (Tired of doing the same setup for every lib.) |
I know! :) PS: Glad to help. |
Thanks again! I'll merge tomorrow. |
Good idea! Thanks for the link. |
Wow this PR clarifies the build process a lot and makes it easier to start hacking on redux. 👍 |
(Window compatibility)
I mentioned it in gaearon/library-boilerplate#2. Should work for Mac as well (I hope) to make it all cross-platform. The no space after setting variable is the hack discovery that makes it possible in Windows. |
@mikekidder This doesn't pass |
I tried to fix Windows build in #379. |
Yes, "set" on OS X was questionable, I didn't have a Mac to test. I'll respond further in #379 |
This supersedes #248
/cc @gaearon