fully move away from index.d.ts #3561
Conversation
|
Also, we should add the |
tsconfig.json
Outdated
| // "declaration": true /* Generates corresponding '.d.ts' file. */, | ||
| // "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, | ||
| "declaration": true /* Generates corresponding '.d.ts' file. */, | ||
| "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, |
There was a problem hiding this comment.
question: is this useful? It pops a sourcemap into the types/ directory but I'm not sure anyone would use it?
There was a problem hiding this comment.
Does VS Code pick this up when I hit Go To Definition? That's what I would assume to use it for.
I'm inclined to thing they're not useful, though.
There was a problem hiding this comment.
another question: Do we still need the .d.ts files? Can't we just distribute src/ now?
There was a problem hiding this comment.
Not the individual ones, just the main index.d.ts. Rewinding back a bit, I would expect that to be in the package root like it is now.
We already put the src into the package verbatim.
There was a problem hiding this comment.
so is there any reason we can't do "typings": "src/index.ts"?
There was a problem hiding this comment.
Not the individual ones, just the main
index.d.ts. Rewinding back a bit, I would expect that to be in the package root like it is now.
I tried to do this, it isn't possible in an automatic way, because typescript automatically ignores the directory we tell it to pop its results into, probably to avoid infinite loops.
We can just manually cp types/index.d.ts . but it seems unnecessary to me. I haven't seen any other examples out there that keep any autogenerated files in the repo
Also, I checked, and no one is using "types": "index.ts" so I'm going to assume it's a bad idea
There was a problem hiding this comment.
Ah yes, we don't need definitions because we are fully TS'ed now.
There was a problem hiding this comment.
@timdorr "Go to Definition" doesn't work like that with sourcemaps.
@cellog "types": "index.ts" is definitely a bad idea, as the types are supposed to point to a .d.ts file. All TS files should be gone when you publish to npm.
@timdorr do you mean we don't need manually-typed definitions? Correct. Still need auto-generated ones though.
There was a problem hiding this comment.
We publish src now. We want that in the package so the source is always available to read through. It's small and I consider it an important feature of Redux.
Whether we use that for our types or not, it's going to stay in the package.
|
I think we are ready? @timdorr anything I missed? |
Co-Authored-By: Jed Mao <jedmao@users.noreply.github.com>
cellog
force-pushed
the
cellog-3500-generate-index.d.ts
branch
from
b54a776 to
291c263
Compare
|
ok, just rebased this, when it's done, should be good to go |
* fully move away from index.d.ts * build types into the types/ directory * remove autogenerated types dir * ignore auto-generated types * better type building, also clean old definitions * use types instead of typings Co-Authored-By: Jed Mao <jedmao@users.noreply.github.com> * Don't build declaration maps Former-commit-id: 20c995c Former-commit-id: cc5bb53
* fully move away from index.d.ts * build types into the types/ directory * remove autogenerated types dir * ignore auto-generated types * better type building, also clean old definitions * use types instead of typings Co-Authored-By: Jed Mao <jedmao@users.noreply.github.com> * Don't build declaration maps Former-commit-id: 20c995c Former-commit-id: cc5bb53
this is it! after this, typescript conversion is complete