Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to help travis build all examples #375

Merged
merged 1 commit into from
Jul 31, 2015

Conversation

quicksnap
Copy link
Contributor

Doesn't run the tests yet, but can easily do so. If this looks good, Travis will need to run npm build:examples

@quicksnap
Copy link
Contributor Author

This is good because at least if there are syntax errors with the examples it will catch them.

@quicksnap
Copy link
Contributor Author

#157 #374

@quicksnap quicksnap force-pushed the example_build_tools branch from 4d79709 to 4fbd159 Compare July 31, 2015 00:00
@gaearon
Copy link
Contributor

gaearon commented Jul 31, 2015

This looks good per se, how do we make Travis run it now?

@quicksnap
Copy link
Contributor Author

I don't know.. as the owner, do you have a way to make Travis run commands?

@quicksnap
Copy link
Contributor Author

I'm reading up on Travis docs right now.. maybe somewhere in travis.yml

@quicksnap quicksnap force-pushed the example_build_tools branch from 4fbd159 to 1879d00 Compare July 31, 2015 00:18
@quicksnap
Copy link
Contributor Author

Nice! I modified the travis.yml and it did it. You can see the results here: https://travis-ci.org/gaearon/redux/builds/73478113

gaearon added a commit that referenced this pull request Jul 31, 2015
Add script to help travis build all examples
@gaearon gaearon merged commit 4358fc4 into reduxjs:breaking-changes-1.0 Jul 31, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 31, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants