experiment: clean $CombinedState out from getState

[phryneas]

Hey @markerikson take a look - does this solve reduxjs/redux-toolkit#2068 ?

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e2d1c7c:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration

[github-actions]

Size Change: 0 B

Total Size: 8.62 kB

ℹ️ View Unchanged

Filename	Size	Change
dist/redux.js	6.9 kB	0 B
dist/redux.min.js	1.72 kB	0 B

_{compressed-size-action}

[markerikson]

Just tried this. It does fix the issue... if you infer type RootState = ReturnType<typeof store.getState>. However, it does not fix the issue if you infer directly from ReturnType<typeof rootReducer>. Which is what I suspected might happen.

So clearly something is going on with Reselect and that $CombinedState type.

[mpeyper]

This would likely be a workable solution for my issue, as just having an option to erase the $CombinedState would at least keep me moving, but I agree with @markerikson that it doesn't actually solve the root of the issue.

[markerikson]

Where does this idea stand? I think I saw us talking recently about dropping $CombinedState completely? What does that even do, anyway?