Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redux.dev course callouts #4748

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

lynnandtonic
Copy link
Contributor

@lynnandtonic lynnandtonic commented Oct 31, 2024

Hi Mark! This PR:

  • Updates the docs website
  • Adds three SVG images for redux.dev callouts (narrow, mid, and wide sizes)
  • Adds the mid size callout to the homepage

I wasn’t sure how to add the callouts to the internal docs pages (I’m not super familiar with docusaurus), is that something you could help me with?

Here is where I was thinking we could place them (either mid at the bottom of the main column or narrow in the right sidebar). Also open to your suggestions here!

callout-placement-docs

We could also potentially add the wide one above the nav (only on the homepage) if we wanted it higher up on the page. (Though not great for mobile and we’d probably want to hide or swap out there)

callout-placement-home

Let me know what you think works and if there’s anything else I can provide. Thanks!

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit b7ce658
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/672407fc27954b00081d9f9e
😎 Deploy Preview https://deploy-preview-4748--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson
Copy link
Contributor

Thanks! Since the PR is from your master branch, I'll just merge this and then fiddle with it a bit - probably going to add the "wide" version as a sitewide banner for the next few weeks. I'll also add it to the RTK and React-Redux sites as well.

@markerikson markerikson merged commit 56aaa38 into reduxjs:master Nov 7, 2024
12 checks passed
@markerikson
Copy link
Contributor

Done! Updated all 3 docs sites ( https://redux.js.org, https://redux-toolkit.js.org , https://react-redux.js.org ) with the same top banner and front-page image.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants