Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getReducer() from Store API #668

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Remove getReducer() from Store API #668

merged 1 commit into from
Aug 31, 2015

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 31, 2015

It was only needed because React Redux used it to magically allow reducer hot reloading.
This magic used to cause problems (#301, #340), so we made the usage of replaceReducer() for hot reloading explicit (#667). Now that it is explicit, there is no need for getReducer() so it can safely be removed from the public API.

This is a breaking change, so it goes into wip-2.0 branch.

gaearon added a commit that referenced this pull request Aug 31, 2015
Remove getReducer() from Store API
@gaearon gaearon merged commit 982ab86 into wip-2.0 Aug 31, 2015
@gaearon gaearon deleted the remove-get-reducer branch August 31, 2015 23:39
@quicksnap
Copy link
Contributor

Can we issue a deprecation warning in development builds for getReducer?

@quicksnap
Copy link
Contributor

(In the 1.0 branch that is)

@gaearon
Copy link
Contributor Author

gaearon commented Aug 31, 2015

We can, although I expect it to be called by React Redux in 99% cases. I don't think anybody else used it..

We need to release React Redux 2.0 that wouldn't use it.

@quicksnap
Copy link
Contributor

Given Redux's small API surface, it's probably overkill if there's no affordance for it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants