Make setState return the state that was set #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
added a commit
that referenced
this pull request
Jun 13, 2015
Make setState return the state that was set
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #68, #62
I want to make this change to make custom dispatchers more composable.
The store is still managed by the “main” dispatcher, but now wrappers (such as a time travelling wrapper) are able to intercept the state that dispatcher is attempting to set, and, perhaps, put information of their own there too.
With this change, the
setStatecall bubbles from the innermost dispatcher up to the Redux instance, and goes back with the state that was actually set.