Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating docs: point to createStore() source file #801

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Migrating docs: point to createStore() source file #801

merged 1 commit into from
Sep 25, 2015

Conversation

julen
Copy link
Contributor

@julen julen commented Sep 25, 2015

Feel free to close the PR if you disagree, although since it suggests to check the createStore implementation, I think it makes more sense to link to it, rather than to the API docs.

@imevro
Copy link
Contributor

imevro commented Sep 25, 2015

I think more useful have both links. Docs explains idea, but source shows code behind the idea.

@gaearon
Copy link
Contributor

gaearon commented Sep 25, 2015

Yes, I would rather have both. You can add " (source)" after the API link where "source" itself is a link.

@julen
Copy link
Contributor Author

julen commented Sep 25, 2015

Thank you for the feedback, updated accordingly.

gaearon added a commit that referenced this pull request Sep 25, 2015
Migrating docs: point to `createStore()` source file
@gaearon gaearon merged commit 3f02418 into reduxjs:master Sep 25, 2015
@julen julen deleted the docs/migrating branch September 25, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants