Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and rethrow error from reducer init in combineReducers #717 #807

Merged

Conversation

ellbee
Copy link
Contributor

@ellbee ellbee commented Sep 26, 2015

No description provided.

@gaearon
Copy link
Contributor

gaearon commented Sep 26, 2015

Looks good to me. Can you please verify this fixes the original problem?

You can

  1. Check out Migrate real-world example to redux-router #714
  2. Introduce an error inside any reducer
  3. Make sure DevTools now show the error

@ellbee
Copy link
Contributor Author

ellbee commented Sep 26, 2015

Yep, I'm out for the day now but I'll get on it tomorrow.

@gaearon gaearon merged commit 6fd9b05 into reduxjs:master Sep 26, 2015
@gaearon
Copy link
Contributor

gaearon commented Sep 26, 2015

Confirm this issue is fixed.
I took the liberty to refactor a bit: a1485f0
Thank you very much for your help here and on other projects.

@ellbee
Copy link
Contributor Author

ellbee commented Sep 27, 2015

👍 for the refactorings.

And thank you for this awesome project. I am happy I could contribute something back.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants