Throws an error when select not returns an object
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Connector, verify if `select` prop, which is a function, returns an object, and if not, throws an error. Issue reduxjs#78
| @@ -59,6 +60,11 @@ export default function createConnector(React) { | |||
| selectState({ context, props } = this) { | |||
| const state = context.redux.getState(); | |||
| const slice = props.select(state); | |||
|
|
|||
| if (!isPlainObject(slice)) { | |||
There was a problem hiding this comment.
Great! Let's use invariant?
import invariant from 'invariant';
// ...
invariant(
isPlainObject(slice),
'The return value of `select` prop must be an object. Instead received %s.',
slice
);
|
👍 |
gaearon
added a commit
that referenced
this pull request
Jun 13, 2015
…ject Throws an error when `select` not returns an object
|
Awesome, thank you! |
|
Mb i'm wrong, but you need to add babel transform to strip invariant message in production like this https://github.com/facebook/react/blob/master/vendor/constants.js |
|
I actually don't mind having message in production (it's not that long and we only have very few). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Connector, verify if
selectprop, which is a function, returns anobject, and if not, throws an error.
Issue #78