-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Selector types for correct extension #240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 15 15
=====================================
Hits 15 15 Continue to review full report at Codecov.
|
1 similar comment
I've removed interface extension completely to address #241 |
2 similar comments
This should remain backward-compatible because the last commit could only potentially break TS 2.1 users who extend For TS 2.2 extending intersection type will work fine. |
I realized that I didn't add a test for this, please don't merge yet. |
Done. |
1 similar comment
when will this be published ? |
cc. @ellbee |
I think we can go ahead with that |
@ellbee et. al: can we get a 3.0.1 release with this fixed please? |
Please merge! |
@alex3165 Feel free to release and publish if you think this is good to go. |
Merged, released and published with the patch version |
Thanks @alex3165! |
Fixes #237.
This is backwards-compatible.