Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selector types for correct extension #240

Merged
merged 4 commits into from
May 10, 2017

Conversation

aikoven
Copy link
Contributor

@aikoven aikoven commented Mar 30, 2017

Fixes #237.
This is backwards-compatible.

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 1d6b934 on aikoven:fix-typings into fb8dd53 on reactjs:master.

@codecov-io
Copy link

codecov-io commented Mar 30, 2017

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #240   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8dd53...b0f1565. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 30bf21a on aikoven:fix-typings into fb8dd53 on reactjs:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 30bf21a on aikoven:fix-typings into fb8dd53 on reactjs:master.

@aikoven
Copy link
Contributor Author

aikoven commented Apr 7, 2017

I've removed interface extension completely to address #241

@aikoven aikoven changed the title Update Selector types to be interfaces for correct extension Update Selector types for correct extension Apr 7, 2017
@coveralls
Copy link

coveralls commented Apr 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 56c1856 on aikoven:fix-typings into fb8dd53 on reactjs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 56c1856 on aikoven:fix-typings into fb8dd53 on reactjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 56c1856 on aikoven:fix-typings into fb8dd53 on reactjs:master.

@aikoven
Copy link
Contributor Author

aikoven commented Apr 7, 2017

This should remain backward-compatible because the last commit could only potentially break TS 2.1 users who extend OutputSelector interface, but TS 2.1 support is already broken in 3.0.0 (see #237).

For TS 2.2 extending intersection type will work fine.

@aikoven
Copy link
Contributor Author

aikoven commented Apr 9, 2017

I realized that I didn't add a test for this, please don't merge yet.

@aikoven
Copy link
Contributor Author

aikoven commented Apr 12, 2017

Done.

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b0f1565 on aikoven:fix-typings into fb8dd53 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b0f1565 on aikoven:fix-typings into fb8dd53 on reactjs:master.

@aikoven aikoven mentioned this pull request Apr 13, 2017
@danielduhh
Copy link

when will this be published ?

@aikoven
Copy link
Contributor Author

aikoven commented Apr 16, 2017

cc. @ellbee

@alex3165
Copy link
Contributor

I think we can go ahead with that

@the-destro
Copy link

@ellbee et. al: can we get a 3.0.1 release with this fixed please?

@richarddavenport
Copy link

Please merge!

@ellbee
Copy link
Collaborator

ellbee commented May 8, 2017

@alex3165 Feel free to release and publish if you think this is good to go.

@alex3165 alex3165 merged commit 9806798 into reduxjs:master May 10, 2017
@alex3165
Copy link
Contributor

Merged, released and published with the patch version 3.0.1

@ellbee
Copy link
Collaborator

ellbee commented May 11, 2017

Thanks @alex3165!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants