Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided memoize function for selectors #297

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

srolel
Copy link
Contributor

@srolel srolel commented Nov 11, 2017

In addition to memoizedResultFunc.

In addition to memoizedResultFunc
@coveralls
Copy link

coveralls commented Nov 11, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f0c8af4 on Mosho1:patch-1 into 92d16de on reactjs:master.

@codecov-io
Copy link

codecov-io commented Nov 11, 2017

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #297   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d16de...f0c8af4. Read the comment docs.

@skortchmark9
Copy link

@ellbee could you take a look at this? It would be really handy to have in

@ellbee ellbee merged commit fda697a into reduxjs:master Jun 22, 2018
@ellbee
Copy link
Collaborator

ellbee commented Jun 22, 2018

Ok, this looks good to me. Will be released in version 4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants